Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STDCM v2 #7348

Merged
merged 5 commits into from
May 15, 2024
Merged

STDCM v2 #7348

merged 5 commits into from
May 15, 2024

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Apr 30, 2024 •
edited
Loading

close #7346

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 34.51143% with 315 lines in your changes are missing coverage. Please review.

Project coverage is 29.13%. Comparing base (5b12cb9) to head (dd21355).

Files Patch % Lines
editoast/src/views/v2/timetable/stdcm.rs 15.32% 105 Missing ⚠️
...n/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt 0.00% 90 Missing ⚠️
...tlin/fr/sncf/osrd/api/api_v2/RequirementsParser.kt 0.00% 36 Missing ⚠️
...in/fr/sncf/osrd/api/api_v2/stdcm/STDCMRequestV2.kt 0.00% 31 Missing ⚠️
...n/fr/sncf/osrd/api/api_v2/stdcm/STDCMResponseV2.kt 0.00% 18 Missing ⚠️
editoast/src/views/v2/path/pathfinding.rs 0.00% 12 Missing ⚠️
...rd/api/api_v2/standalone_sim/RollingStockParser.kt 0.00% 5 Missing ⚠️
front/src/common/api/osrdEditoastApi.ts 96.35% 5 Missing ⚠️
...pi/api_v2/conflicts/ConflictDetectionEndpointV2.kt 0.00% 2 Missing ⚠️
...rd/api/api_v2/standalone_sim/SimulationResponse.kt 0.00% 2 Missing ⚠️
... and 8 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7348      +/-   ##
============================================
- Coverage     29.15%   29.13%   -0.02%     
+ Complexity     2012     2011       -1     
============================================
  Files          1164     1170       +6     
  Lines        144102   144475     +373     
  Branches       2811     2822      +11     
============================================
+ Hits          42013    42094      +81     
- Misses       100428   100717     +289     
- Partials       1661     1664       +3
Flag Coverage Δ
core 75.25% <5.52%> (-0.99%) ⬇️
editoast 72.33% <15.86%> (-0.31%) ⬇️
front 9.80% <96.35%> (+0.07%) ⬆️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster force-pushed the stdcm-v2 branch 2 times, most recently from 6e920c3 to c9621f4 Compare May 3, 2024 10:44
@Erashin Erashin force-pushed the stdcm-v2 branch 2 times, most recently from c2d7fca to 90ea65b Compare May 7, 2024 07:50
@Erashin Erashin marked this pull request as ready for review May 7, 2024 07:50
@Erashin Erashin requested review from a team as code owners May 7, 2024 07:50
@Erashin Erashin requested a review from multun May 7, 2024 07:50
eckter
eckter reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed core

I'd like to run some integration tests at some points (at least with an updated fuzzer)

core/src/main/kotlin/fr/sncf/osrd/api/api_v2/RequirementsParser.kt Outdated Show resolved Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/RequirementsParser.kt Outdated Show resolved Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/pathfinding/PathfindingBlocksEndpointV2.kt Outdated Show resolved Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt Show resolved Hide resolved
@flomonster flomonster requested a review from a team as a code owner May 10, 2024 09:05
@Erashin Erashin force-pushed the stdcm-v2 branch 2 times, most recently from 11f49d4 to 56f4fbc Compare May 14, 2024 09:01
@younesschrifi younesschrifi force-pushed the stdcm-v2 branch 2 times, most recently from 1166d88 to 0393270 Compare May 14, 2024 09:49
eckter
eckter approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for core

@flomonster flomonster removed the request for review from multun May 14, 2024 16:21
SharglutDev
SharglutDev reviewed May 14, 2024
View reviewed changes
front/src/common/api/osrdEditoastApi.ts Show resolved Hide resolved
front/src/common/api/osrdEditoastApi.ts Show resolved Hide resolved
front/src/common/api/osrdEditoastApi.ts Show resolved Hide resolved
front/src/common/api/osrdEditoastApi.ts Show resolved Hide resolved
front/public/locales/en/errors.json Outdated Show resolved Hide resolved
front/public/locales/en/errors.json Outdated Show resolved Hide resolved
woshilapin
woshilapin approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work, thank you 🎉 Just a few naming comments, nothing blocking for merging on editoast's side.

editoast/src/views/v2/timetable/stdcm.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/timetable/stdcm.rs Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the stdcm-v2 branch 4 times, most recently from 0355838 to f579321 Compare May 15, 2024 12:37
@younesschrifi younesschrifi force-pushed the stdcm-v2 branch 2 times, most recently from d7c05e3 to f68d71b Compare May 15, 2024 14:12
SharglutDev
SharglutDev approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@younesschrifi younesschrifi added this pull request to the merge queue May 15, 2024
Merged via the queue into dev with commit 31078d8 May 15, 2024
17 checks passed
@younesschrifi younesschrifi deleted the stdcm-v2 branch May 15, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erashin Erashin Erashin left review comments

@younesschrifi younesschrifi younesschrifi left review comments

@SharglutDev SharglutDev SharglutDev approved these changes

@eckter eckter eckter approved these changes

@woshilapin woshilapin woshilapin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS2: Add STDCM endpoint core + editoast
7 participants
@flomonster @codecov-commenter @woshilapin @eckter @younesschrifi @Erashin @SharglutDev