Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add utoipa annotation for infra/{id}/speed_limit_tags #7331

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 29, 2024

Part of #4580

@hamz2a hamz2a requested review from a team as code owners April 29, 2024 10:07
@hamz2a hamz2a changed the title editoast: add utoipa annotation for infra/{id}/speed_limit_tags editoast: add utoipa annotation for infra/{id}/speed_limit_tags Apr 29, 2024
editoast/openapi.yaml Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-id-speed-limit-tags branch 2 times, most recently from 961b449 to 27747f9 Compare April 30, 2024 09:33
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 29.10%. Comparing base (f72ba7f) to head (7adad66).

Files Patch % Lines
...src/applications/editor/components/LayersModal.tsx 0.00% 5 Missing ⚠️
...src/common/Map/Settings/MapSettingsSpeedLimits.tsx 0.00% 2 Missing ⚠️
...Selector/useStoreDataForSpeedLimitByTagSelector.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #7331   +/-   ##
=========================================
  Coverage     29.09%   29.10%           
  Complexity     2020     2020           
=========================================
  Files          1137     1137           
  Lines        139647   139655    +8     
  Branches       2757     2757           
=========================================
+ Hits          40635    40642    +7     
- Misses        97403    97404    +1     
  Partials       1609     1609           
Flag Coverage Δ
core 76.76% <ø> (ø)
editoast 72.08% <100.00%> (+<0.01%) ⬆️
front 9.34% <59.09%> (+<0.01%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-id-speed-limit-tags branch from 27747f9 to 7adad66 Compare April 30, 2024 14:15
@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-id-speed-limit-tags branch from 7adad66 to 93c192e Compare April 30, 2024 15:16
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hamz2a hamz2a added this pull request to the merge queue Apr 30, 2024
Merged via the queue into dev with commit 113dbd9 Apr 30, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-utoipa-annotation-for-infra-id-speed-limit-tags branch April 30, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants