Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display bpcc in infra editor #7329

Merged
merged 1 commit into from
May 7, 2024

Conversation

RomainValls
Copy link
Contributor

@RomainValls RomainValls commented Apr 29, 2024

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 29.01%. Comparing base (6b648d8) to head (ea57726).
Report is 4 commits behind head on dev.

Files Patch % Lines
...mon/Map/Layers/extensions/SNCF/NeutralSections.tsx 0.00% 16 Missing ⚠️
front/src/applications/editor/Map.tsx 0.00% 9 Missing ⚠️
...mulationResult/components/SimulationResultsMap.tsx 0.00% 9 Missing ⚠️
front/src/applications/referenceMap/Map.tsx 0.00% 7 Missing ⚠️
...ainschedule/components/ManageTrainSchedule/Map.tsx 0.00% 7 Missing ⚠️
...src/applications/editor/components/LayersModal.tsx 0.00% 5 Missing ⚠️
front/src/config/layerOrder.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7329      +/-   ##
============================================
- Coverage     29.14%   29.01%   -0.13%     
  Complexity     2016     2016              
============================================
  Files          1141     1157      +16     
  Lines        139977   142351    +2374     
  Branches       2769     2809      +40     
============================================
+ Hits          40793    41309     +516     
- Misses        97568    99388    +1820     
- Partials       1616     1654      +38     
Flag Coverage Δ
core 76.29% <ø> (ø)
editoast 71.99% <ø> (-0.01%) ⬇️
front 9.66% <5.26%> (+0.29%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls force-pushed the rvs/front-display-bpcc-in-infra-editor branch from 61b390d to 57e0f04 Compare May 7, 2024 09:38
@RomainValls RomainValls marked this pull request as ready for review May 7, 2024 09:41
@RomainValls RomainValls requested a review from a team as a code owner May 7, 2024 09:41
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ tested

@RomainValls RomainValls force-pushed the rvs/front-display-bpcc-in-infra-editor branch from ea57726 to cbfc8bf Compare May 7, 2024 13:01
@RomainValls RomainValls force-pushed the rvs/front-display-bpcc-in-infra-editor branch from cbfc8bf to 813feca Compare May 7, 2024 13:03
@RomainValls RomainValls added this pull request to the merge queue May 7, 2024
Merged via the queue into dev with commit 052ad62 May 7, 2024
17 checks passed
@RomainValls RomainValls deleted the rvs/front-display-bpcc-in-infra-editor branch May 7, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants