Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: adding source extension for tracksection #7249

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Apr 17, 2024

see #6997

Implementing the source extension in osrd-schema (and editoast) for TrackSection.
Its data are composed of a name and an id.

osrd-schema has been bumped to 0.8.11

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.91%. Comparing base (c645608) to head (1243f85).
Report is 28 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7249       +/-   ##
=============================================
- Coverage     28.20%   10.91%   -17.29%     
=============================================
  Files          1135      601      -534     
  Lines        139480   100488    -38992     
  Branches       2801      930     -1871     
=============================================
- Hits          39334    10970    -28364     
+ Misses        98515    88593     -9922     
+ Partials       1631      925      -706     
Flag Coverage Δ
core ?
editoast ?
front 9.15% <ø> (+0.03%) ⬆️
gateway 2.43% <ø> (-0.02%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51 sim51 force-pushed the bsi/issue-6997 branch 2 times, most recently from a7c30e3 to a371649 Compare April 18, 2024 12:46
see #6997
bump version of schema to 0.8.11
@sim51 sim51 marked this pull request as ready for review April 18, 2024 13:17
@sim51 sim51 requested a review from a team as a code owner April 18, 2024 13:17
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the preparation work.

@sim51 sim51 added this pull request to the merge queue Apr 18, 2024
Merged via the queue into dev with commit 93552a3 Apr 18, 2024
17 checks passed
@sim51 sim51 deleted the bsi/issue-6997 branch April 18, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants