Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: fix railjson_generator bug (simulation_builder) #6230

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

shenriotpro
Copy link
Contributor

No description provided.

@shenriotpro shenriotpro added kind:bug Something isn't working area:railjson Work on Proposed Unified Rail Assets Data Exchange Format severity:minor Minor severity bug component:railjson-generator python Pull requests that update Python code labels Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c12f67) 26.90% compared to head (5c66c5b) 26.90%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6230   +/-   ##
=========================================
  Coverage     26.90%   26.90%           
  Complexity     2139     2139           
=========================================
  Files           932      932           
  Lines        123970   123970           
  Branches       2689     2689           
=========================================
  Hits          33352    33352           
  Misses        89013    89013           
  Partials       1605     1605           
Flag Coverage Δ
core 78.87% <ø> (ø)
editoast 75.34% <ø> (ø)
front 9.47% <ø> (ø)
gateway 2.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shenriotpro shenriotpro marked this pull request as ready for review December 28, 2023 14:44
@shenriotpro shenriotpro requested a review from a team as a code owner December 28, 2023 14:44
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenriotpro shenriotpro added this pull request to the merge queue Dec 28, 2023
Merged via the queue into dev with commit c2cbdfe Dec 28, 2023
18 checks passed
@shenriotpro shenriotpro deleted the shenriot-fix-railjson branch December 28, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:railjson Work on Proposed Unified Rail Assets Data Exchange Format component:railjson-generator kind:bug Something isn't working python Pull requests that update Python code severity:minor Minor severity bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants