editoast: magic wand revamp #6210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
force-pushed
the
wsl/refactor/5856-auto-fix-revamp
branch
2 times, most recently
from
2030abe to
57d840b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6210 +/- ##
============================================
- Coverage 27.30% 26.93% -0.37%
Complexity 2136 2136
============================================
Files 952 961 +9
Lines 124900 124258 -642
Branches 2690 2574 -116
============================================
- Hits 34106 33472 -634
- Misses 89189 89297 +108
+ Partials 1605 1489 -116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hamz2a
approved these changes
Dec 26, 2023
leovalais
approved these changes
Dec 26, 2023
bougue-pe
force-pushed
the
wsl/refactor/5856-auto-fix-revamp
branch
from
35ff70d to
583b3f9
Compare
bougue-pe
reviewed
Jan 2, 2024
woshilapin
force-pushed
the
wsl/refactor/5856-auto-fix-revamp
branch
from
583b3f9 to
d4d0b51
Compare
If we want to keep opportunities to parallelize this code, all the errors related to the same object should be addressed together. It will become important when some `Operation::Update` will happen and need to be ordered correctly.
woshilapin
force-pushed
the
wsl/refactor/5856-auto-fix-revamp
branch
from
8d0cf43 to
24faeea
Compare
|
Tests are going in another PR (to avoid blocking other work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to keep opportunities to parallelize this code, all the errors related to the same object should be addressed together. It will become important when some
Operation::Updatewill happen and need to be ordered correctly.Still missing some tests on (can take inspiration on
fn fix_track_section()):fn fix_catenary()fn fix_detector()fn fix_operational_point()fn fix_route()fn fix_signal()fn fix_speed_section()fn fix_switch()