Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump osrd-ui 0.0.59 #10233

Merged
merged 2 commits into from
Jan 6, 2025
Merged

bump osrd-ui 0.0.59 #10233

merged 2 commits into from
Jan 6, 2025

Conversation

SharglutDev
Copy link
Contributor

See commits

close #8629

@SharglutDev SharglutDev requested a review from a team as a code owner January 3, 2025 16:18
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (4d2a487) to head (1429110).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10233      +/-   ##
==========================================
- Coverage   81.44%   81.43%   -0.02%     
==========================================
  Files        1058     1058              
  Lines      104266   104271       +5     
  Branches      722      722              
==========================================
- Hits        84922    84914       -8     
- Misses      19303    19316      +13     
  Partials       41       41              
Flag Coverage Δ
editoast 73.58% <ø> (-0.05%) ⬇️
front 89.18% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/bump-osrd-ui-0.0.59 branch from ecd344c to e758cf2 Compare January 3, 2025 16:24
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested :)

@Maymanaf Maymanaf requested a review from a team as a code owner January 6, 2025 13:40
Signed-off-by: SharglutDev <p.filimon75@gmail.com>

front: fix time and tolerance modal not closing for e2e tests

Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
Signed-off-by: SharglutDev <p.filimon75@gmail.com>
@SharglutDev SharglutDev force-pushed the pfn/front/bump-osrd-ui-0.0.59 branch from 32dbd50 to 1429110 Compare January 6, 2025 15:52
@SharglutDev SharglutDev enabled auto-merge January 6, 2025 15:53
@SharglutDev SharglutDev added this pull request to the merge queue Jan 6, 2025
Merged via the queue into dev with commit c474d24 Jan 6, 2025
28 checks passed
@SharglutDev SharglutDev deleted the pfn/front/bump-osrd-ui-0.0.59 branch January 6, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manchette : hide a waypoint by clicking on it
6 participants