editoast: endpoints to retrieve stdcm payloads

[hamz2a]

Part of #9724

Warning

We need to wait for this PR to be merged before merging that one.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.88196% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.78%. Comparing base (d7e5438) to head (587adc5).
Report is 11 commits behind head on dev.

Files with missing lines	Patch %	Lines
front/src/common/api/generatedEditoastApi.ts	60.00%	6 Missing ⚠️
editoast/src/client/runserver.rs	0.00%	4 Missing ⚠️
editoast/src/views/stdcm_logs.rs	98.40%	4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10212      +/-   ##
==========================================
+ Coverage   81.67%   81.78%   +0.10%     
==========================================
  Files        1071     1072       +1     
  Lines      106107   106452     +345     
  Branches      727      727              
==========================================
+ Hits        86663    87058     +395     
+ Misses      19405    19355      -50     
  Partials       39       39              

Flag	Coverage Δ
editoast	74.20% <98.15%> (+0.44%)	⬆️
front	89.35% <60.00%> (-0.01%)	⬇️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.50% <ø> (ø)
tests	87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[woshilapin]

Nice work, especially on the tests! I left a few comments.

[woshilapin]

Thank you for all the improvements, I've resolved most of my comments (only left one opened, feel free to resolve if you fix, if you disagree, either way).

[leovalais]

LGTM, thank you for all the changes!

[SharglutDev]

Lgtm

[leovalais]

While trying to test the new endpoints I cam across a few bugs 🥲

With authorization disabled:

With authorization enabled, the first request works, but its trace id is 00000000.....
The second request fails:

Steps to reproduce:

1. (I loaded a new DB dump)
2. Authorization enabled
3. Open the frontend
4. Give mock.identity the role Superuser
5. LMR request
6. The log appear on DB with trace-id 00000000000...
7. Another LMR request
8. Contraint violation

[woshilapin]

Really nice and exhaustive suite of tests. Thank you.

[leovalais]

Thanks a lot for all the changes! I'll test it a bit to make sure I didn't miss anything but things look fine to me :)

[leovalais]

Sorry found a new problem:

❯ xh :8090/stdcm_logs x-remote-user-identity:'mock.identity/Example User'
HTTP/1.1 400 Bad Request
Access-Control-Allow-Origin: *
Content-Length: 190
Content-Type: application/json
Date: Thu, 16 Jan 2025 11:31:29 GMT
Vary: origin, access-control-request-method, access-control-request-headers

{
    "status": 400,
    "type": "editoast:pagination:InvalidPageSize",
    "context": {
        "max_page_size": 10,
        "provided_page_size": 25
    },
    "message": "Invalid page size (25), expected an integer 0 < page_size <= 10"
}

[hamz2a]

Sorry found a new problem:

❯ xh :8090/stdcm_logs x-remote-user-identity:'mock.identity/Example User'
HTTP/1.1 400 Bad Request
Access-Control-Allow-Origin: *
Content-Length: 190
Content-Type: application/json
Date: Thu, 16 Jan 2025 11:31:29 GMT
Vary: origin, access-control-request-method, access-control-request-headers

{
    "status": 400,
    "type": "editoast:pagination:InvalidPageSize",
    "context": {
        "max_page_size": 10,
        "provided_page_size": 25
    },
    "message": "Invalid page size (25), expected an integer 0 < page_size <= 10"
}

The error occurs because the default value for pagination is 25, but for this endpoint, we've set it to 10 as specified in the pagination validation.

[hamz2a]

As we discussed, we'll keep the page_size at 25, but the endpoint is less verbose, it now returns results like: [{'id': 1, 'trace_id': 'AZERT'}, {'id': 2, 'trace_id': null}].
I've also updated the endpoint to allow access to the logs byid.

[leovalais]

Thanks and sorry about all the back and forth! I can see a few things to improve (especially the /stdcm_log vs /stdcm_logS, these mistakes are hard to find 😨), but that's for another PR if any. Let's merge this :)