-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "DSDM" from the download simulation sheet message #10155
Remove "DSDM" from the download simulation sheet message #10155
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10155 +/- ##
==========================================
+ Coverage 79.84% 81.42% +1.58%
==========================================
Files 1054 1057 +3
Lines 105571 104207 -1364
Branches 726 720 -6
==========================================
+ Hits 84292 84855 +563
+ Misses 21237 19310 -1927
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I don't find the mockup with this message, could you give the name of the related mockup or issue ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the issue description is empty, I don't know what is DSDM and why it needs to be removed, also the english translate file should be modified right?
848614e
to
22197d1
Compare
Issue modified and english wording validated :) |
Signed-off-by: Achraf Mohyeddine <a.mohyeddine@gmail.com>
22197d1
to
3211a69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Closes #10156