Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "DSDM" from the download simulation sheet message #10155

Merged

Conversation

achrafmohye
Copy link
Contributor

@achrafmohye achrafmohye commented Dec 20, 2024

Closes #10156

@achrafmohye achrafmohye self-assigned this Dec 20, 2024
@achrafmohye achrafmohye requested a review from a team as a code owner December 20, 2024 11:08
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (1033678) to head (3211a69).
Report is 82 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10155      +/-   ##
==========================================
+ Coverage   79.84%   81.42%   +1.58%     
==========================================
  Files        1054     1057       +3     
  Lines      105571   104207    -1364     
  Branches      726      720       -6     
==========================================
+ Hits        84292    84855     +563     
+ Misses      21237    19310    -1927     
  Partials       42       42              
Flag Coverage Δ
editoast 73.58% <ø> (-0.18%) ⬇️
front 89.18% <ø> (+0.02%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev
Copy link
Contributor

I don't find the mockup with this message, could you give the name of the related mockup or issue ?

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue description is empty, I don't know what is DSDM and why it needs to be removed, also the english translate file should be modified right?

@achrafmohye achrafmohye force-pushed the ame/remove-dsdm-download-message-stdcm-report-sheet branch from 848614e to 22197d1 Compare January 2, 2025 10:42
@achrafmohye
Copy link
Contributor Author

I don't find the mockup with this message, could you give the name of the related mockup or issue ?

the issue description is empty, I don't know what is DSDM and why it needs to be removed, also the english translate file should be modified right?

Issue modified and english wording validated :)

Signed-off-by: Achraf Mohyeddine <a.mohyeddine@gmail.com>
@achrafmohye achrafmohye force-pushed the ame/remove-dsdm-download-message-stdcm-report-sheet branch from 22197d1 to 3211a69 Compare January 2, 2025 13:44
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@achrafmohye achrafmohye added this pull request to the merge queue Jan 6, 2025
Merged via the queue into dev with commit d4cf6c4 Jan 6, 2025
27 checks passed
@achrafmohye achrafmohye deleted the ame/remove-dsdm-download-message-stdcm-report-sheet branch January 6, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "DSDM" from the download simulation sheet message
5 participants