editoast: better sql query to split a track section #10030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim51
force-pushed
the
bsi/issue-8947
branch
from
b4d0582 to
15fc415
Compare
sim51
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10030 +/- ##
==========================================
+ Coverage 80.06% 80.09% +0.03%
==========================================
Files 1050 1054 +4
Lines 105423 105648 +225
Branches 757 759 +2
==========================================
+ Hits 84405 84619 +214
- Misses 20977 20988 +11
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sim51
force-pushed
the
bsi/issue-8947
branch
2 times, most recently
from
ddfb790 to
d24ace6
Compare
Fix #8947 New query is not using the `ST_LineSubstring` which gives bad result with geography data that has long segment. By computing the geo point and doing a split of the TS near this point, it's a lot better. Signed-off-by: Benoit Simard <contact@bsimard.com>
sim51
force-pushed
the
bsi/issue-8947
branch
from
d24ace6 to
bdf07d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8947
New query is not using the
ST_LineSubstringwhich gives bad result with geography data that has long segment. By computing the geo point and doing a split of the TS near this point, it's a lot better.