search.c: Fix build failure due new GCC #1132
Conversation
The warning by GCC is false positive because we don't access the freed memory in the scope, only the pointer memory which contained address of allocated memory on the heap, and used that for updating index pointer. Using ptrdiff_t struct before realloc works the warning around.
There was a problem hiding this comment.
I really hate this crap - the warnings are bogus but they still push them out.
Note the code scanning report that the "if (lword)" before the free is no longer necessary, at least for CUPS 2.5.x. For CUPS 2.4.x (that still targets ANSI C) you want the NULL check.
The other way I got recommendation for is pragma, which I haven't used yet so I was inclined to try it, but this looks cleaner :( .
Nice, I did not know about it! Read man page more, Zdenek :) ... |
The warning by GCC is false positive because we don't access the freed memory in the scope, only the pointer memory which contained address of allocated memory on the heap, and used that for updating index pointer.
Using ptrdiff_t struct before realloc works the warning around.