Create efficient, order-preserving container for object tags #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task: GH-1290 (revision-control friendly file format) |
dg0yt
force-pushed
the
tags-order
branch
3 times, most recently
from
b98a434 to
1c366f7
Compare
...but no behavioural change at this point: This is a subclass of the type formerly aliased as Object::Tags.
For object tags, we want to preserve the insertion order in order to maintain a VCS-friendly file format. It is reasonable to assume that the number of tags per object is low. (In fact, it is zero for most objects unless imported from sources such as OSM.) This commit implements an interface similar to std::map (for insertion and lookup) for pairs of QString (key, value) on top of std::vector (for order and locality), and it adjusts all spots which access object tags. Task: GH-1290 (VCS-friendly file format)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.