fix: Solution The set command cache does not take effect

[Mixficsol]

解决了 Set 命令更新 Cache 不生效的问题，原因在于使用 Set 命令时设置 TTL 为 0
issue: #3014

Summary by CodeRabbit

• Bug Fixes
  • Improved cache expiration logic by converting TTL values only when they are positive, ensuring that non-positive TTL values remain unchanged for more reliable behavior.

[coderabbitai]

Walkthrough

The changes refine TTL handling in cache operations. In both SetCmd::DoUpdateCache and GetCmd::DoUpdateCache, TTL values are now divided by 1000 only when the TTL is greater than zero. Non-positive TTLs remain unchanged, ensuring that only valid TTL values are converted. This adjustment prevents unintended behavior arising from dividing zero or negative TTL values.

Changes

File	Change Summary
src/pika_kv.cc	Modified both SetCmd::DoUpdateCache and GetCmd::DoUpdateCache to conditionally divide TTL by 1000 only if the TTL is > 0.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client
    participant SetCmd as SetCmd::DoUpdateCache
    participant GetCmd as GetCmd::DoUpdateCache

    Client ->> SetCmd: Call update cache (with ttl)
    SetCmd ->> SetCmd: Check if ttl > 0?
    alt ttl > 0
        SetCmd ->> SetCmd: Divide ttl by 1000
    else ttl <= 0
        SetCmd -->> SetCmd: Use ttl as-is
    end

    Client ->> GetCmd: Call update cache (with ttl)
    GetCmd ->> GetCmd: Check if ttl > 0?
    alt ttl > 0
        GetCmd ->> GetCmd: Divide ttl by 1000
    else ttl <= 0
        GetCmd -->> GetCmd: Use ttl as-is
    end

Loading

Possibly related PRs

• fix: pksetexat should update cache #2736: Similar modifications in the DoUpdateCache method of the PKSetexAtCmd class suggest a related logic update in handling TTL values.

Suggested labels

🧹 Updates

Suggested reviewers

• chejinge
• AlexStocks

Poem

In my burrow deep, I found a tweak,
Where TTL values now play hide and seek.
Positive ones shrink with a division so neat,
While zero or negative stay complete.
Coding carrots, oh what a treat! 🐰
Hop along, for our cache is now elite!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92db19e and 1814869.

📒 Files selected for processing (1)

• src/pika_kv.cc (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: build_on_ubuntu
• GitHub Check: build_on_centos
• GitHub Check: Analyze (go)
• GitHub Check: build_on_macos

🔇 Additional comments (2)

src/pika_kv.cc (2)

114-114: LGTM! The fix correctly handles zero TTL values.

The change ensures that TTL division only occurs for positive values, fixing the issue where Set command cache was not taking effect when TTL was 0.

---

194-194: LGTM! Consistent TTL handling across commands.

The change ensures consistent TTL handling between Set and Get commands, maintaining proper cache behavior for zero TTL values.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.