Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete iter before returns #2785

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: delete iter before returns #2785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f38b3d
delete iter before return
Jul 6, 2024
6976fee
delete iter before return
Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/storage/src/redis_strings.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1748,6 +1748,7 @@ rocksdb::Status Redis::PKPatternMatchDel(const std::string& pattern, int32_t* re
batch.Clear();
} else {
*ret = total_delete;
delete iter;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the iterator is deleted before returning.

The delete iter; statement should be added before the return statement at line 1751 to prevent memory leaks.

+        delete iter;
         return s;
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
delete iter;
delete iter;
return s;

return s;
}
}
Expand All @@ -1761,6 +1762,7 @@ rocksdb::Status Redis::PKPatternMatchDel(const std::string& pattern, int32_t* re
}
}

delete iter;
*ret = total_delete;
return s;
}
Expand Down
Loading