Settings for more control over special deal prices #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added
Type: Enhancement
fenhl
force-pushed
the
shop-price-settings
branch
from
6a4612e to
35e8feb
Compare
|
I think this is the kind of thing I'd rather leave as a plando-only feature... This level of control over something so specific feels like GUI bloat |
cjohnson57
added
Status: Waiting for Author
|
I'm not sure if it's possible to add this functionality for plando while keeping the current interface for GUI settings. Might have to move this feature outside settings to achieve that. Will have to give it some more thought. |
cjohnson57
added
Status: Needs Review
cjohnson57
reviewed
Jan 14, 2025
cjohnson57
approved these changes
Jan 14, 2025
fenhl
added
Status: Waiting for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing as an alternative to #1899. Instead of arbitrarily using the betavariate distribution for some price ranges and the uniform distribution for others, this PR adds settings to control the price range and distribution individually. As a bonus feature, I've also added an option to have each special deal location use the price of its vanilla item. Something like the features suggested in the comments of #1987 could be implemented as another option of this setting.