feat: Add Pull Request model and integrate with sync_repository #845
Conversation
space-techy
force-pushed
the
feature/github-pull-request-tracking
branch
from
e92aef2 to
c56972a
Compare
space-techy
force-pushed
the
feature/github-pull-request-tracking
branch
from
c56972a to
0aff313
Compare
space-techy
force-pushed
the
feature/github-pull-request-tracking
branch
from
35bfb89 to
022555a
Compare
space-techy
force-pushed
the
feature/github-pull-request-tracking
branch
2 times, most recently
from
ded2dc4 to
6f7b568
Compare
space-techy
force-pushed
the
feature/github-pull-request-tracking
branch
from
6f7b568 to
181ec78
Compare
space-techy
force-pushed
the
feature/github-pull-request-tracking
branch
from
181ec78 to
ad3fe10
Compare
|
@arkid15r Please Don't Forget this PR! |
| @@ -83,6 +84,56 @@ def sync_repository(gh_repository, organization=None, user=None): | |||
| else: | |||
| logger.info("Skipping issues sync for %s", repository.name) | |||
|
|
|||
| if not repository.is_archived and repository.project: | |||
There was a problem hiding this comment.
I suggest applying the same logic we use for issues sync (see above). It fetches all states and has a cut off date if it's not the very first sync.
There was a problem hiding this comment.
You are talking about that since argument passed to **kwargs in issue?
If you are then since is not available in PR!
There was a problem hiding this comment.
Let's try fetching PRs sorted by updated and break the loop when we see a date earlier than our latest_updated_at (if any)?
There was a problem hiding this comment.
We can sort by the created-at field to retrieve the earliest date after the first fetch is complete. For subsequent runs, we can use this date. If the closed pull request’s date is older than the stored date, we can simply skip it.
| from apps.github.models.mixins import IssueIndexMixin | ||
|
|
||
|
|
||
| class PullRequest(BulkSaveModel, IssueIndexMixin, NodeModel, TimestampedModel): |
There was a problem hiding this comment.
Every PR is an issue according to GH docs. They have a lot of attributes in common. I think it'd be a good idea to use a base GenericIssueModel for both entities and extend them as needed.
There was a problem hiding this comment.
Ya it's a great Idea!
Let me check on it and inform you!
There was a problem hiding this comment.
Also to confirm you want me to make a common model for both Pull request Model and Issues Model? And extend it?
There was a problem hiding this comment.
Yes, extract the common fields to GenericIssueModel abstract model.
Resolves #825
Changes
PullRequestModel: Introduced a new model to store GitHub pull request data, including fields liketitle,body,state,author,repository,created_at, andmerged_at.sync_repository: Integrated PR syncing logic to fetch and update pull requests using GitHub’s API.PullRequestmodel to enable management via the Django admin panel.User,Repository,Labels, andAssignees.This update enables automatic tracking and management of GitHub pull requests within OWASP Nest.