-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.to.rast: Give verbose message about number for all types #2498
base: main
Are you sure you want to change the base?
Conversation
When there are no areas in the vector map, v.to.rast gives warning, 'No areas selected'. This makes the behavior consistent for all types, so same warning is generated for points, lines, boundaries, and centroids. The default for type is point, line, and area, so for a common vector map with a single type (point, line, or area), the default parameters now produce two warnings.
This PR addresses point 2 from #2459 by adding warnings for other types instead of removing the one for areas as #2459 does. The types with this PR behave consistently resulting always in two warnings in the example cases. Examples beforePoints without this PR result in one warning:
Areas without this PR result in no warning:
Examples afterPoints with this PR result in two warnings:
Areas with this PR result in two warnings:
|
This is still somewhat valid even after #2459 was merged because the warnings can be turned into verbose messages and than it would be very consistent across types even with verbose. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
v.to.rast now give consistent verbose message about number for all features for all types. The PR is ready for review. |
@wenzeslaus I'll let you merge, so you can adapt the commit message, as the first commit was close to the original description of this PR (using warning), but changed just now. It'll make more sense if you do it |
When there are no areas in the vector map, v.to.rast gave warning. After #2459, it gives a verbose message about number of selected areas when areas are selected as type. This gives the verbose message for all types when they are selected making the behavior more consistent across types (points, lines, boundaries, and centroids).
The default for type is point, line, and area, so three verbose messages are produced (when verbose output is enabled) for any vector map. (For the original version PR - as an alternative to #2459 with warnings consistent with the behavior before #2459 - a common vector map with a single type (point, line, or area) and the default parameters would produce two warnings.)