Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro forma PR - do not merge #619

Closed
wants to merge 4 commits into from
Closed

Pro forma PR - do not merge #619

wants to merge 4 commits into from

Conversation

busstoptaktik
Copy link
Member

What happens to tests if we get rid of proj_def.dat? See #201

@kbevers
Copy link
Member

kbevers commented Oct 20, 2017

You are not going to get away with removing WGS84 as the default ellipsoid :-)

@busstoptaktik
Copy link
Member Author

@kbevers sang:

You are not going to get away with removing WGS84 as the default ellipsoid :-)

(see my recent comment over at #201)

@kbevers
Copy link
Member

kbevers commented Oct 20, 2017

I meant for this test... Try changing the default to GRS80 and see how big the impact on the test data is.

@busstoptaktik
Copy link
Member Author

I meant for this test

That will be my next commit. Until now, I just want to see how bad it gets (how many non-express assumptions are, at least, in the code - apparently calcofi depends hard on WGS84, which would make sense if talking about the datum, but not the ellipsoid)

@busstoptaktik
Copy link
Member Author

Fails miserably, but only (?) due to the expected submillimetric differences in testvarious output file tv_out. Mostly a matter of creating a new tv_out.dist file.

@kbevers
Copy link
Member

kbevers commented Oct 21, 2017

It doesn't look that bad actually. It is at most 5 or 6 test cases that are affected. Should be easy enough to check if they are something other deviations on the 8th decimal, which is most likely the case. An updated tv_out.dist is definitely the way to go then.

@busstoptaktik
Copy link
Member Author

(Closing for now, having gained the insight, that solving the technical aspect of this is not a big problem. Deferring further work until this has been discussed on the mailing list - hopefully first after next release)

@busstoptaktik busstoptaktik deleted the proj-def-dot-dat-undeffed branch November 4, 2017 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants