-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pro forma PR - do not merge #619
Pro forma PR - do not merge #619
Conversation
You are not going to get away with removing WGS84 as the default ellipsoid :-) |
I meant for this test... Try changing the default to GRS80 and see how big the impact on the test data is. |
That will be my next commit. Until now, I just want to see how bad it gets (how many non-express assumptions are, at least, in the code - apparently calcofi depends hard on WGS84, which would make sense if talking about the datum, but not the ellipsoid) |
Fails miserably, but only (?) due to the expected submillimetric differences in |
It doesn't look that bad actually. It is at most 5 or 6 test cases that are affected. Should be easy enough to check if they are something other deviations on the 8th decimal, which is most likely the case. An updated |
(Closing for now, having gained the insight, that solving the technical aspect of this is not a big problem. Deferring further work until this has been discussed on the mailing list - hopefully first after next release) |
What happens to tests if we get rid of proj_def.dat? See #201