Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 9.0] Improve documentation plotting of interrupted projections. #3145

Merged
merged 1 commit into from
Mar 28, 2022
Merged

[Backport 9.0] Improve documentation plotting of interrupted projections. #3145

merged 1 commit into from
Mar 28, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport 7d8e728 from #3144

@erykoff @github-actions
Improve documentation plotting of interrupted projections. (#3144)
9928f83 
Improves the documentation plotting code by adding checks for interrupted lines and graticules. This does not replace the continental outlines with filled continents because that is a harder job. A number of plots has been improved and included in the docs.

Also fixes a typo on the ob_tran plot so that it now renders as intended according to the description paragraph as an oblique Mollweide rather than oblique Miller Cylindrical, which is neither a common nor attractive projection.
@kbevers
Copy link
Member

kbevers commented Mar 28, 2022

@hobu we get this in the travis build that publishes the docs:

Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

I assume it's from the docker pull line in /~https://github.com/OSGeo/PROJ/blob/master/travis/docker.sh. Is there anything we can do about this?

@hobu
Copy link
Contributor

hobu commented Mar 28, 2022

osgeo/proj-docs probably needs to be moved away from dockerhub to github. I had pushed an older version of the container to /~https://github.com/OSGeo/PROJ/pkgs/container/proj-docs This should be updated and we should update our recipes.

@kbevers
Copy link
Member

kbevers commented Mar 28, 2022

osgeo/proj-docs probably needs to be moved away from dockerhub to github

Sounds like a good options. Do you mind writing an issue that lays out a plan for that transition? If I remember correctly GDAL and PDAL are also using this image, right?

On the Docker pricing website it says that you get 200 pulls per 6 hours, so I assume this job can be restarted in a couple of hours and it should run without problems, correct?

@hobu hobu mentioned this pull request Mar 28, 2022
Closed
@hobu
Copy link
Contributor

hobu commented Mar 28, 2022

Sounds like a good options. Do you mind writing an issue that lays out a plan for that transition? If I remember correctly GDAL and PDAL are also using this image, right?

Not much transition needed. Just point at the OSGeo org's image
/~https://github.com/PDAL/PDAL/pull/3721/files

@kbevers kbevers merged commit 325595e into 9.0 Mar 28, 2022
@kbevers kbevers deleted the backport-3144-to-9.0 branch March 28, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbevers @hobu @erykoff