Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geoid for Caribbean Netherlands (Bonaire) #133

Closed
wants to merge 1 commit into from

Conversation

Jochem-L
Copy link
Contributor

No description provided.

@rouault
Copy link
Member

rouault commented Jan 23, 2025

There are also other files to update as detailed in /~https://github.com/OSGeo/PROJ-data/blob/master/CONTRIBUTING.md
Cf /~https://github.com/OSGeo/PROJ-data/pull/114/files as an example that should be close to what you need to do

@Jochem-L
Copy link
Contributor Author

@rouault Thanks for pointing to CONTRIBUTING.md! I should have read that much earlier.

Only now I notice we created a consistency problem. We published the geoid grid for Bonaire as bq_nsgi_bongeo2004.tif However, CONTRIBUTING.md mentions that the two-letter country code refers to the agency nationality, not the country code of the area the grid is intended for. So we should have used the country code nl instead of bq? I checked some other countries with overseas parts that have their own country codes, and indeed grids for these overseas parts are in the same directory as the grids for the mainland.

Shall we rename the geoid grid file to nl_nsgi_bongeo2004.tif and put it in the directory nl_nsgi? In that case this pull request for bq_nsgi_bongeo2004.tif in the directory bq_nsgi should not be merged...

@rouault
Copy link
Member

rouault commented Jan 27, 2025

Shall we rename the geoid grid file to nl_nsgi_bongeo2004.tif and put it in the directory nl_nsgi? I

yes that would be more consistent

In that case this pull request for bq_nsgi_bongeo2004.tif in the directory bq_nsgi should not be merged...

your choice if you want to amend it, or re-open a fresh one.

@Jochem-L Jochem-L closed this by deleting the head repository Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants