Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Tensorrt Plugins from source #799

Merged
merged 6 commits into from
Sep 25, 2021
Merged

Build Tensorrt Plugins from source #799

merged 6 commits into from
Sep 25, 2021

Conversation

ichergui
Copy link
Member

@ichergui ichergui commented Sep 14, 2021 •
edited
Loading

In this PR:

  • Split tensorrt recipe to tensorrt-core, tensorrt-plugins-prebuilt and tensorrt-samples recipes.
  • Add new recipe to build tensorrt-plugins from source.
  • Update dependency list in recipes which depends on tensorrt-core and tensorrt-plugins.

Signed-off-by: Ilies CHERGUI ilies.chergui@gmail.com

@ichergui ichergui requested a review from madisongh September 14, 2021 01:05
@ichergui ichergui changed the title DON'T MERGE: recipes-devtools: add tensorrt recipe recipes-devtools: add tensorrt recipe Sep 15, 2021
@ichergui
Copy link
Member Author

ichergui commented Sep 15, 2021 •
edited
Loading

This PR is related to this discussion #793

@ichergui ichergui changed the title recipes-devtools: add tensorrt recipe Build Tensorrt Plugins from source Sep 17, 2021
madisongh
madisongh requested changes Sep 18, 2021
View reviewed changes
Copy link
Member

@madisongh madisongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See in-line comments

conf/layer.conf Outdated Show resolved Hide resolved
recipes-devtools/gie/tensorrt-core_8.0.1-1.bb Outdated Show resolved Hide resolved
recipes-devtools/gie/tensorrt-plugins_8.0.1-1.bb Outdated Show resolved Hide resolved
recipes-devtools/gie/tensorrt-plugins_8.0.1-1.bb Outdated Show resolved Hide resolved
recipes-devtools/gie/tensorrt-plugins_8.0.1-1.bb Outdated Show resolved Hide resolved
@ichergui ichergui requested a review from madisongh September 20, 2021 22:14
@ichergui ichergui self-assigned this Sep 21, 2021
@bcis93 bcis93 mentioned this pull request Sep 22, 2021
Closed
madisongh
madisongh requested changes Sep 23, 2021
View reviewed changes
Copy link
Member

@madisongh madisongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's getting there. Just a couple of minor in-line comments.

recipes-devtools/gie/tensorrt-samples_8.0.1-1.bb Outdated Show resolved Hide resolved
recipes-devtools/gie/tensorrt-samples_8.0.1-1.bb Outdated Show resolved Hide resolved
external/openembedded-layer/recipes-devtools/gie/tensorrt-plugins_8.0.1-1.bb Outdated Show resolved Hide resolved
@ichergui ichergui requested a review from madisongh September 23, 2021 23:58
madisongh
madisongh requested changes Sep 25, 2021
View reviewed changes
Copy link
Member

@madisongh madisongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more minor things to check

recipes-devtools/gie/tensorrt-samples_8.0.1-1.bb Outdated Show resolved Hide resolved
recipes-devtools/gie/tensorrt-plugins-prebuilt_8.0.1-1.bb Outdated Show resolved Hide resolved
external/openembedded-layer/recipes-devtools/gie/tensorrt-plugins_8.0.1-1.bb Outdated Show resolved Hide resolved
@ichergui
tensorrt: split recipe to tensorrt-core, tensorrt-plugins-prebuilt
47257fc 
and tensorrt-samples recipes.

some of the recipes depends only on tensorrt-core.

Signed-off-by: Ilies CHERGUI <ilies.chergui@gmail.com>
@ichergui
tensorrt-plugins: add recipe
b46deb3 
to build TensorRT Plugins from source.

Signed-off-by: Ilies CHERGUI <ilies.chergui@gmail.com>
@ichergui
conf/layer.conf: update recipe name
81ebbb3 
Signed-off-by: Ilies CHERGUI <ilies.chergui@gmail.com>
@ichergui
python3-tensorrt: add tensorrt-core and tensorrt-plugins in the depen…
2b896bb 
…dency list

Signed-off-by: Ilies CHERGUI <ilies.chergui@gmail.com>
@ichergui
deepstream-5.1: add tensorrt-core and tensorrt-plugins in the dependency
f356b73 
list

Signed-off-by: Ilies CHERGUI <ilies.chergui@gmail.com>
@ichergui
tegra-mmapi-samples: add tensorrt-core and tensorrt-plugins in the
1cce0be 
PACKAGECONFIG list

Signed-off-by: Ilies CHERGUI <ilies.chergui@gmail.com>
@madisongh madisongh merged commit ca80fa8 into OE4T:master Sep 25, 2021
@ichergui ichergui deleted the wip-build-tensorrt-from-src branch September 25, 2021 17:39
bcis93 added a commit to sighthoundinc/meta-tegra that referenced this pull request Sep 26, 2021
@bcis93
Copying latest changes from PR OE4T#799
b35ae2a
bcis93 added a commit to sighthoundinc/meta-tegra that referenced this pull request Sep 26, 2021
@bcis93
Copying latest changes from PR OE4T#799
4b778d6
bcis93 added a commit to sighthoundinc/meta-tegra that referenced this pull request Sep 26, 2021
@bcis93
Copying latest changes from PR OE4T#799
35a4a17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madisongh madisongh madisongh approved these changes

Assignees

@ichergui ichergui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichergui @madisongh