Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] partner_contact_department: really order by name #2009

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] partner_contact_department: really order by name #2009

wants to merge 1 commit into from

Conversation

yajo
Copy link
Member

@yajo yajo commented Feb 25, 2025

First attempt in #1983 didn't really work because parent_path always contained own ID.

Now departments will really be ordered by name, or by parent path + name if they have a parent.

@moduon MT-8760

@yajo
[FIX] partner_contact_department: really order by name
722401c 
First attempt in OCA#1983 didn't really work because `parent_path` always contained own ID.

Now departments will really be ordered by name, or by parent path + name if they have a parent.

@moduon MT-8760
@yajo yajo self-assigned this Feb 25, 2025
@yajo yajo requested review from Shide, rafaelbn and fcvalgar February 25, 2025 11:38
@yajo yajo added this to the 16.0 milestone Feb 25, 2025
@yajo yajo added the bug label Feb 25, 2025
@yajo yajo mentioned this pull request Feb 25, 2025
Merged
fcvalgar
fcvalgar approved these changes Feb 25, 2025
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review,
LGTM, thank you @yajo .

image

image

rafaelbn
rafaelbn approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2009-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 25, 2025
@OCA-git-bot
Merge PR #2009 into 16.0
ddb5d6d 
Signed-off-by rafaelbn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

@Shide Shide Awaiting requested review from Shide

Assignees

@yajo yajo

Labels
approved bot is merging ⏳ bug
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yajo @OCA-git-bot @rafaelbn @fcvalgar