Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mermaid version and re-enable visualize task (v3) #6388

Merged
merged 2 commits into from
Feb 24, 2025
Merged

update mermaid version and re-enable visualize task (v3) #6388

merged 2 commits into from
Feb 24, 2025

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Feb 21, 2025

fixes #6291

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 726fe76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nomicfoundation/ignition-ui Patch
@nomicfoundation/hardhat-ignition Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ❌ Failed (Inspect) Feb 24, 2025 3:35pm

@zoeyTM zoeyTM requested review from kanej and alcuadrado February 21, 2025 05:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

hardhat

Total size of the bundle: 215M
Total number of dependencies (including transitive): 54

List of dependencies (sorted by size) 
209M	total
29M	@ignored/edr-optimism-linux-x64-musl
29M	@ignored/edr-optimism-linux-x64-gnu
26M	@ignored/edr-optimism-linux-arm64-musl
26M	@ignored/edr-optimism-linux-arm64-gnu
22M	@ignored/edr-optimism-win32-x64-msvc
20M	esbuild
20M	@ignored/edr-optimism-darwin-x64
19M	@ignored/edr-optimism-darwin-arm64
2.8M	@sentry/tracing
2.5M	micro-eth-signer
1.9M	@noble/curves
1.7M	undici
1.2M	@sentry/types
1.2M	@noble/hashes
932K	@sentry/node
920K	@sentry/utils
856K	zod
844K	@nomicfoundation/hardhat-utils
624K	micro-packed
576K	tsx
548K	@sentry/core
544K	fast-equals
492K	@scure/bip39
368K	ethereum-cryptography
348K	@nomicfoundation/hardhat-errors
344K	@sentry/hub
336K	@ignored/edr
320K	enquirer
288K	semver
280K	@ignored/edr-optimism
196K	ws
168K	@scure/base
136K	get-tsconfig
136K	adm-zip
96K	@scure/bip32
92K	chalk
88K	tslib
88K	@sentry/minimal
76K	agent-base
72K	@nomicfoundation/solidity-analyzer
68K	debug
64K	lru_map
64K	https-proxy-agent
60K	@nomicfoundation/hardhat-zod-utils
56K	rfdc
48K	ansi-colors
44K	resolve.exports
40K	resolve-pkg-maps
36K	p-map
32K	cookie
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	ms

alcuadrado
alcuadrado approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the update fixes the rendering (I haven't checked), these changes LGTM

@zoeyTM zoeyTM added the no changeset needed This PR doesn't require a changeset label Feb 21, 2025
@zoeyTM zoeyTM enabled auto-merge February 21, 2025 16:18
@zoeyTM zoeyTM disabled auto-merge February 21, 2025 16:18
@zoeyTM zoeyTM added no changeset needed This PR doesn't require a changeset and removed status:triaging no changeset needed This PR doesn't require a changeset labels Feb 21, 2025
kanej
kanej approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this merged on Monday.

@zoeyTM zoeyTM removed the no changeset needed This PR doesn't require a changeset label Feb 24, 2025
@zoeyTM zoeyTM enabled auto-merge February 24, 2025 15:51
@zoeyTM zoeyTM disabled auto-merge February 24, 2025 15:51
@kanej kanej merged commit 942d9af into v-next Feb 24, 2025
117 of 118 checks passed
@kanej kanej deleted the fix/mermaid-text branch February 24, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanej kanej kanej approved these changes

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@kanej kanej

Labels
None yet
Projects
Hardhat
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoeyTM @kanej @alcuadrado