You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MMenchero and I need to contribute to this feature and there is some codependence on each other's code. So we cannot merge the final product to main yet.
We can involve you when we are ready to merge to main if that is what you would prefer. At this stage we are just looking for initial feedback in case something is glaringly off so that we don't have to do a major rework at the end when we submit the PR to main.
I don't understand why you didn't just merge the branches locally and opened the PR towards main, the diff in this PR is meaningless if the base branch already has changes. Also I don't understand the difference between getting feedback in a PR towards main and here, since you've already done the work.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat/data_audit
first since @MMenchero and I are collaborating on it and may need to iron out a few things before we merge to main.