Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findex: 0.7.1 -> 0.7.2 #219032

Closed
wants to merge 1 commit into from
Closed

findex: 0.7.1 -> 0.7.2 #219032

wants to merge 1 commit into from

Conversation

olifloof
Copy link
Contributor

@olifloof olifloof commented Mar 1, 2023 •
edited
Loading

Description of changes

/~https://github.com/mdgaziur/findex/releases/tag/v0.7.2

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@olifloof olifloof requested a review from SuperSandro2000 March 1, 2023 18:37
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 1, 2023
@AndersonTorres
Copy link
Member

Broken on Darwin.

@olifloof
Copy link
Contributor Author

olifloof commented Mar 2, 2023

It's not intended for darwin
/~https://github.com/pinkcreeper100/nixpkgs/blob/86e58f56f409248383ca2e24a4f101b4b6eac374/pkgs/applications/misc/findex/default.nix#L45

@olifloof
Copy link
Contributor Author

olifloof commented Mar 2, 2023

and the linux builds fail because upstream forgot to update the cargo lockfile

@AndersonTorres
Copy link
Member

  1. Recreate the lockfile and use cargoLock.lockfile = ./Cargo.lock.
    Also in the postPatch substitute the lockfile.

  2. Add meta.badPlatforms = [ "aarch64-darwin" "x86_64-darwin" ];

@olifloof
Copy link
Contributor Author

olifloof commented Mar 3, 2023

I'd preferably just wait until it's fixed upstream

@olifloof
Copy link
Contributor Author

olifloof commented Mar 3, 2023

added meta.badPlatforms

@AndersonTorres
Copy link
Member

OK. I will put this on draft mode until they sort out that new lockfile.

@olifloof olifloof marked this pull request as draft March 4, 2023 06:08
@olifloof olifloof mentioned this pull request Mar 15, 2023
Merged
@olifloof
Copy link
Contributor Author

decided to make a pr to update it myself

@olifloof
Copy link
Contributor Author

I've kinda given up on this, as upstream development has halted

@olifloof olifloof closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres requested changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olifloof @AndersonTorres