Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: fix build with Linux >=5.18 #180263

Closed
wants to merge 1 commit into from
Closed

zfs: fix build with Linux >=5.18 #180263

wants to merge 1 commit into from

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented Jul 5, 2022

Description of changes

Fixes #179551

To make it possible to build ZFS 2.1.5 against Linux 5.18 we have to disable
this specific error condition. Judging from this comment [1] on the ZFS issue
tracker, upstream doesn't compile with -Werror at all, so it is safe to disable
turning this warning into an error.

[1] openzfs/zfs#13622 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@hmenke
zfs: fix build with Linux >=5.18
999ff44 
To make it possible to build ZFS 2.1.5 against Linux 5.18 we have to disable
this specific error condition.  Judging from this comment [1] on the ZFS issue
tracker, upstream doesn't compile with -Werror at all, so it is safe to disable
turning this warning into an error.

[1] openzfs/zfs#13622 (comment)
@hmenke
Copy link
Member Author

hmenke commented Jul 5, 2022

@schwarmco Please review.

@hmenke hmenke requested a review from PedroHLC July 5, 2022 17:39
@ofborg ofborg bot requested review from globin, jonringer, fpletz, jcumming and wizeman July 5, 2022 17:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 labels Jul 5, 2022
@PedroHLC
Copy link
Member

PedroHLC commented Jul 5, 2022 •
edited
Loading

Important to note, ZFS is not alone, this was the fix in kernel-side: #175433

@hmenke
Copy link
Member Author

hmenke commented Jul 5, 2022

So maybe the fix I propose is not even necessary anymore. Has the staging iteration containing that fix already landed? Then we should also backport #175433 to staging-22.05 otherwise this will remain broken on stable NixOS.

@PedroHLC
Copy link
Member

PedroHLC commented Jul 5, 2022

So maybe the fix I propose is not even necessary anymore. Has the staging iteration containing that fix already landed? Then we should also backport #175433 to staging-22.05 otherwise this will remain broken on stable NixOS.

Looks like you figured it out, we have it in staging, while it's missing in 22.05.

@hmenke
Copy link
Member Author

hmenke commented Jul 6, 2022

Superseded by #180275

@hmenke hmenke closed this Jul 6, 2022
@hmenke hmenke deleted the zfs branch July 11, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroHLC PedroHLC Awaiting requested review from PedroHLC

@globin globin Awaiting requested review from globin

@jonringer jonringer Awaiting requested review from jonringer

@fpletz fpletz Awaiting requested review from fpletz

@jcumming jcumming Awaiting requested review from jcumming

@wizeman wizeman Awaiting requested review from wizeman

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zfs 2.15 fails to build with kernel 5.18.6
2 participants
@hmenke @PedroHLC