zfs: fix build with Linux >=5.18 #180263
Closed
zfs: fix build with Linux >=5.18 #180263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it possible to build ZFS 2.1.5 against Linux 5.18 we have to disable this specific error condition. Judging from this comment [1] on the ZFS issue tracker, upstream doesn't compile with -Werror at all, so it is safe to disable turning this warning into an error. [1] openzfs/zfs#13622 (comment)
|
@schwarmco Please review. |
ofborg
bot
added
11.by: package-maintainer
|
Important to note, ZFS is not alone, this was the fix in kernel-side: #175433 |
|
So maybe the fix I propose is not even necessary anymore. Has the staging iteration containing that fix already landed? Then we should also backport #175433 to staging-22.05 otherwise this will remain broken on stable NixOS. |
Looks like you figured it out, we have it in staging, while it's missing in 22.05. |
|
Superseded by #180275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #179551
To make it possible to build ZFS 2.1.5 against Linux 5.18 we have to disable
this specific error condition. Judging from this comment [1] on the ZFS issue
tracker, upstream doesn't compile with -Werror at all, so it is safe to disable
turning this warning into an error.
[1] openzfs/zfs#13622 (comment)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes