Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/forward header provider #8254

Open
wants to merge 34 commits into
base: cleanup/disable-header-only-forward-sync
Choose a base branch
from

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Feb 24, 2025

  • Include Cleanup/disable header only forward sync #8209
  • Move forward header logic into IForwardHeaderProvider. This works like ChainLevelHelper but also for PoS. IPosTransitionHook is consolidated into it.
  • This isolate the consensus of the IBlockDownloader.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

@asdacap asdacap mentioned this pull request Feb 24, 2025
5 tasks
@asdacap asdacap marked this pull request as draft February 25, 2025 12:03
@asdacap asdacap force-pushed the cleanup/disable-header-only-forward-sync branch from 8f72a88 to 0e938b9 Compare February 26, 2025 07:20
@asdacap asdacap marked this pull request as ready for review February 26, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant