Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing documentation for all the shared hooks (and some other) + Fix some inaccuracies #482

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add missing documentation for all the shared hooks (and some other) + Fix some inaccuracies #482

wants to merge 5 commits into from
+229 −73

Conversation

Winkarst-cpu
Copy link
Contributor

No description provided.

Fer3D
Fer3D reviewed Feb 2, 2025
View reviewed changes
Copy link
Contributor

@Fer3D Fer3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Do not change or delete existing hook names; it can break a lot of code.

@Winkarst-cpu
Copy link
Contributor Author

🚫 Do not change or delete existing hook names; it can break a lot of code.

Will see what Alex will say because having two different hook names with completely same meaning is bad.

@offlegaz2
Copy link
Contributor

🚫 Do not change or delete existing hook names; it can break a lot of code.

Will see what Alex will say because having two different hook names with completely same meaning is bad.

Imagine developer writing plugin for Helix with use of area hooks and then updating his framework after your commit. What will be his reaction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fer3D Fer3D Fer3D left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Winkarst-cpu @offlegaz2 @Fer3D