Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
window_icon
andtaskbar_icon
to the window builder.This will accept an optional path to a file to use.
It should work with jpeg, png and ico files.
I have only tested this on windows.
I also updated the
window_config
example to include these two settings, and a rust.ico asset file.There's an ugly
load_icon
function added in notan_winit window.rs but wasn't sure of where else to place it.e.g.