Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update btm battery controls to charge from fuelcell for fuel cell hybrids #1566

Merged
merged 7 commits into from
Nov 16, 2023

Conversation

mjprilliman
Copy link
Collaborator

Description

-Update callback to check for fuel cell hybrid configs for BTM battery charging from fuelcell
-See additional questions on #1560 to determine additional scope of this issue

Fixes #1560

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Nov 13, 2023
@mjprilliman mjprilliman self-assigned this Nov 13, 2023
@mjprilliman mjprilliman mentioned this pull request Nov 15, 2023
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work correctly now. Thanks!

@mjprilliman mjprilliman merged commit 3e3f4ce into develop Nov 16, 2023
4 checks passed
@mjprilliman mjprilliman deleted the charge-fuelcell-btm-hybrids branch November 16, 2023 19:27
@cpaulgilman cpaulgilman added the dev bug Internal bug that should not be included in release notes label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev bug Internal bug that should not be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battery can charge from fuel cell dispatch option not available for hybrid with fuel cell
2 participants