Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calcualtion for fuelcell cost per capacity, update defaults #1564

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

mjprilliman
Copy link
Collaborator

Pull Request Template

Description

-Add equation to calculate installed_per_capacity for fuelcell in hybrid configs
-Update label to reflect Wac rather than Wdc
-Update defaults

Fixes #1562

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Nov 10, 2023
@mjprilliman mjprilliman self-assigned this Nov 10, 2023
@cpaulgilman cpaulgilman added the dev bug Internal bug that should not be included in release notes label Nov 10, 2023
@mjprilliman mjprilliman merged commit fecbc90 into develop Nov 10, 2023
4 checks passed
@mjprilliman mjprilliman deleted the fuelcell-installled-capacity branch November 10, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev bug Internal bug that should not be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total installed cost in $/W hybrid fuel cell installation cost is zero
2 participants