Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update InterconnectingConverter and HVDC structs #1166

Merged
merged 9 commits into from
Oct 1, 2024

update Inf to 1e8

4eb1bea
Select commit
Loading
Failed to load commit list.
Merged

[WIP] Update InterconnectingConverter and HVDC structs #1166

update Inf to 1e8
4eb1bea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 1, 2024 in 0s

84.55% (-0.05%) compared to ee43211

View this Pull Request on Codecov

84.55% (-0.05%) compared to ee43211

Details

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (ee43211) to head (4eb1bea).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/models/supplemental_constructors.jl 50.00% 3 Missing ⚠️
src/models/generated/InterconnectingConverter.jl 75.00% 2 Missing ⚠️
src/models/generated/TwoTerminalHVDCLine.jl 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   84.59%   84.55%   -0.05%     
==========================================
  Files         181      181              
  Lines        8379     8389      +10     
==========================================
+ Hits         7088     7093       +5     
- Misses       1291     1296       +5     
Files with missing lines Coverage Δ
src/parsers/power_models_data.jl 91.98% <ø> (ø)
src/parsers/power_system_table_data.jl 82.36% <100.00%> (ø)
src/models/generated/TwoTerminalHVDCLine.jl 93.10% <50.00%> (-6.90%) ⬇️
src/models/generated/InterconnectingConverter.jl 94.11% <75.00%> (+0.78%) ⬆️
src/models/supplemental_constructors.jl 35.00% <50.00%> (+6.42%) ⬆️