-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update obsproc build for RDHPCS spack-stack and Rocky OS #92
Update obsproc build for RDHPCS spack-stack and Rocky OS #92
Conversation
- Add build/run version files for each supported platform - Add version and modulefiles for new platform (Hercules) - Update build to use new version files - Update .gitignore Refs NOAA-EMC#88
* upstream/dev/gfsv17: Add module purge for building
- Add temporarily ver files to .gitignore - Remove build.ver and run.ver Refs NOAA-EMC#88
Retain functionality on WCOSS2 Refs NOAA-EMC#88
Use new /contrib location after move off /lfs4 Refs NOAA-EMC#88
- Update to include version variable Refs NOAA-EMC#88
- Combine build.spack.ver and run.spack.ver into spack.ver - Set spack_stack_mod_path in ver files and use variable for MODULEPATH in modulefiles Refs NOAA-EMC#88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the suggested changes. These look clean.
Successfully retested build on WCOSS2, Hera, Jet, Orion, and Hercules. |
To avoid loading a default module version when the module version is not set, put "None" as the default so as to raise an error at build/run time if the version is not set. Refs NOAA-EMC#88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you answer my questions before your merge these changes?
Thanks, @KateFriedman-NOAA and @DavidHuber-NOAA! |
Remove jasper, libpng, zlib, and grib_util versions Refs NOAA-EMC#88 Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This PR updates the
dev/gfsv17
branch of obsproc to build with spack-stack installs, which were made post-Rocky8[9] transitions on the R&Ds. This PR also includes an updated spack-stack install on Jet in/contrib
after moving away from thelfs4
filesystem.Similar to updates made for prepobs in its
dev/gfsv17
branch, the build script is updated and the build/run version files are broken out for each supported platform. Since spack-stack (in it's current incarnation) is not yet on WCOSS2, the WCOSS2 build does not sourceobsproc_common.lua
and instead has all of the library module versions loaded in the same modulefile. This should be updated ahead of cutting the obsproc tag for supporting GFSv17.Resolves #88