Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy post-processed sea ice increment for diagnostics #3235

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

shlyaeva
Copy link
Contributor

Description

This change copies post-processed sea ice increment (the increment that was added to CICE restart files, as opposed to the raw increment that was produced by SOCA), so it can be used in the verification/diagnostics.

It also cleans up previously committed code (removes a list of files where it's not needed anymore).

Resolves NOAA-EMC/GDASApp#1402

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

How has this been tested?

  • Clone and build on hera/intel and orion/intel; run C48mx500_3DVarAOWCDA gdasapp tests and offline verification script.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
Requesting review from @RussTreadon-NOAA and @DavidNew-NOAA since this updates the gdasapp hash in the workflow

Copy link
Contributor

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerorahul It looks like the content of the GDASApp hash update is pretty minimal and directly related to the purpose of this PR, so I'm fine with it.

@RussTreadon-NOAA
Copy link
Contributor

Before we move forward with this PR we need to

  1. merge Add option for outputting post-processed soca ice increment jcb-gdas#64 into jcb-gdas develop
  2. update the parm/jcb-gdas hash in Plot postprocessed ice concentration increment GDASApp#1446 to point at jcb-gdas develop
  3. merge Plot postprocessed ice concentration increment GDASApp#1446 into GDASApp develop
  4. update the sorc/gdas.cd hash in Copy post-processed sea ice increment for diagnostics #3235 to point at GDASApp develop

@shlyaeva
Copy link
Contributor Author

I'll work on downstream merges and updates on Tuesday; thank you all for quick reviews and @RussTreadon-NOAA for outlining the steps forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add diagnostic for the "actual" sea ice increment
6 participants