-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy post-processed sea ice increment for diagnostics #3235
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
Requesting review from @RussTreadon-NOAA and @DavidNew-NOAA since this updates the gdasapp hash in the workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aerorahul It looks like the content of the GDASApp hash update is pretty minimal and directly related to the purpose of this PR, so I'm fine with it.
Before we move forward with this PR we need to
|
I'll work on downstream merges and updates on Tuesday; thank you all for quick reviews and @RussTreadon-NOAA for outlining the steps forward! |
Description
This change copies post-processed sea ice increment (the increment that was added to CICE restart files, as opposed to the raw increment that was produced by SOCA), so it can be used in the verification/diagnostics.
It also cleans up previously committed code (removes a list of files where it's not needed anymore).
Resolves NOAA-EMC/GDASApp#1402
Type of change
Change characteristics
How has this been tested?
Checklist