Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation in w3wave and w3iogomd #1339

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Dec 30, 2024

Pull Request Summary

Fix white-space indentation in w3wave and w3iogo

Description

Review of #1337 discovered incorrect indentation in w3wave. This fixes that.

Issue(s) addressed

Issue was not created.

Commit Message

Fix indentation in w3wave and w3iogo

Check list

Testing

Tests are now running (not originally run after only the w3wave updates)

  • How were these changes tested? matrix
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) yes
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? yes hera, intel
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    No changes.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@JessicaMeixner-NOAA JessicaMeixner-NOAA marked this pull request as ready for review December 30, 2024 18:32
@JessicaMeixner-NOAA JessicaMeixner-NOAA changed the title Fix indentation in w3wave Fix indentation in w3wave and w3iogomd Jan 3, 2025
@JessicaMeixner-NOAA
Copy link
Collaborator Author

@mickaelaccensi - I tagged you as a reviewer because I believe you added the w3iogo code. Will confirm there are no answer changes just wanted to let you know.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Note: When looking at the changes in this PR, one thing that will help is to "hide whitespace changes" so that you can see the vast majority of changes are simply white space. I did combine a few lines just because with the white space changes you could fit everything on one line easily.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@sbanihash - My test show no unexpected diffs, so this should be ready for others to review as well.

@sbanihash
Copy link
Collaborator

sbanihash commented Jan 7, 2025 via email

Copy link
Collaborator

@sbanihash sbanihash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Testing showed similar summary output of matrix.comp. Only issue seen unrelated to this PR is test tp2.6 stalling and reaching wall time which has also been reported by @thesser1.

@sbanihash sbanihash merged commit e409f81 into NOAA-EMC:develop Jan 14, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants