Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformize all timelines padding and width #1499

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

Granja5
Copy link

@Granja5 Granja5 commented Feb 26, 2025

Closes #1492

I think it is done, given the differences in how the pages were constructed the exact values of paddings and sizes are different, but visually I think they are almost indistinguishable now.

In another note, shouldn't the restaurant page's week be starting from Sunday?

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (dbdf420) to head (4bcb554).
Report is 38 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1499   +/-   ##
===========================================
- Coverage           11%     11%   -0%     
===========================================
  Files              273     273           
  Lines             7821    7823    +2     
===========================================
  Hits               817     817           
- Misses            7004    7006    +2     

… could, since the code is organized differently and the content is different)
@Granja5 Granja5 requested a review from a team February 26, 2025 02:17
@vitormpp vitormpp requested a review from a team February 26, 2025 10:45
@thePeras thePeras merged commit 193f685 into ui/redesign Feb 26, 2025
6 checks passed
@thePeras thePeras deleted the fix/uniform-timeline-visuals branch February 26, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants