Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: Restaurant Page #1443

Merged
merged 21 commits into from
Feb 6, 2025
Merged

Redesign: Restaurant Page #1443

merged 21 commits into from
Feb 6, 2025

Conversation

abutuc
Copy link

@abutuc abutuc commented Jan 14, 2025

Closes #1392

Latest Visual Version:

Latest Update:

  • The "Asprela" dropdown is not implemented.

@abutuc abutuc marked this pull request as ready for review January 21, 2025 02:15
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page is really looking nice. Some observations I did by checking the code

@abutuc abutuc requested a review from thePeras January 30, 2025 17:34
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0.67568% with 294 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (e253604) to head (380b135).
Report is 25 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff              @@
##           ui/redesign   #1443    +/-   ##
============================================
- Coverage           12%     11%    -0%     
============================================
  Files              267     270     +3     
  Lines             7321    7507   +186     
============================================
+ Hits               816     817     +1     
- Misses            6505    6690   +185     

@abutuc
Copy link
Author

abutuc commented Jan 30, 2025

@thePeras I think I addressed all of the requested changes, in the description of the PR I highlighted two problems that I have no solution for, can you take a look into it?

@abutuc
Copy link
Author

abutuc commented Jan 30, 2025

@thePeras @DGoiana @vitormpp since I only used Phosphor icons, and not any of the svg icons, I would like your feedback regarding the selection I did, more specifically on the "salads", "diet", "meal of the day" and "vegetarian"

@thePeras
Copy link
Member

thePeras commented Jan 30, 2025

Problem 1
The experience I will expect as a User is to immediately hide the restaurant I have just removed from favorite.
Since favorite restaurants are in preferences, with #1071 would be easily to just consume the favorite restaurants' preference and that would rerender. Honestly, I can see another option here I would recommend.

Problem 2
Check the menus here, and some menus come from here

@HenriqueSFernandes
Copy link
Contributor

@abutuc
I'm not sure if this has been mentioned previously, but I noticed that the order of each meal type is inconsistent across different restaurants:

I think it would be nice to always have the same order, for example, the soup could always be first, the salad at the end, etc.
This way, users can quickly find a specific meal type without having to scan through varying arrangements.

Copy link
Contributor

@Process-ing Process-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few questions / suggestions:

@abutuc abutuc requested a review from Process-ing February 6, 2025 15:29
@Process-ing
Copy link
Contributor

Don't forget to resolve the conflicts 👍

@thePeras thePeras force-pushed the redesign/restaurant-page branch from 41b2fd6 to 380b135 Compare February 6, 2025 16:35
@thePeras thePeras merged commit 5dfc0de into ui/redesign Feb 6, 2025
6 checks passed
@thePeras thePeras deleted the redesign/restaurant-page branch February 6, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants