-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign: Restaurant Page #1443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page is really looking nice. Some observations I did by checking the code
packages/uni_app/lib/view/restaurant/widgets/dish_type_dropdown_menu.dart
Outdated
Show resolved
Hide resolved
packages/uni_app/lib/view/restaurant/widgets/restaurant_utils.dart
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ui/redesign #1443 +/- ##
============================================
- Coverage 12% 11% -0%
============================================
Files 267 270 +3
Lines 7321 7507 +186
============================================
+ Hits 816 817 +1
- Misses 6505 6690 +185 |
@thePeras I think I addressed all of the requested changes, in the description of the PR I highlighted two problems that I have no solution for, can you take a look into it? |
Problem 1 Problem 2 |
@abutuc I think it would be nice to always have the same order, for example, the soup could always be first, the salad at the end, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few questions / suggestions:
packages/uni_app/lib/view/restaurant/restaurant_page_view2.dart
Outdated
Show resolved
Hide resolved
packages/uni_app/lib/view/restaurant/widgets/favorite_restaurants_button.dart
Outdated
Show resolved
Hide resolved
Don't forget to resolve the conflicts 👍 |
41b2fd6
to
380b135
Compare
Closes #1392
Latest Visual Version:




Latest Update: