Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt the subsetFonts transform from assetgraph #55

Merged
merged 19 commits into from
Jul 24, 2019
Merged

Adopt the subsetFonts transform from assetgraph #55

merged 19 commits into from
Jul 24, 2019

Conversation

papandreou
Copy link
Collaborator

@papandreou papandreou commented Jul 21, 2019 •
edited
Loading

@Munter, I think this is ready now! Mostly a matter of timing and when we want to release a new assetgraph major.

@papandreou papandreou self-assigned this Jul 21, 2019
@papandreou papandreou mentioned this pull request Jul 21, 2019
Merged
@coveralls
Copy link

coveralls commented Jul 21, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 79

  • 816 of 872 (93.58%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+25.4%) to 88.554%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/downloadGoogleFonts.js 37 38 97.37%
lib/main.js 5 6 83.33%
lib/unquote.js 4 5 80.0%
lib/normalizeFontPropertyValue.js 17 20 85.0%
lib/subsetLocalFont.js 25 29 86.21%
lib/gatherStylesheetsWithPredicates.js 32 37 86.49%
lib/subsetFonts.js 525 531 98.87%
lib/getCssRulesByProperty.js 54 89 60.67%
Totals Coverage Status
Change from base Build 71: 25.4%
Covered Lines: 897
Relevant Lines: 970
💛 - Coveralls

@papandreou papandreou marked this pull request as ready for review July 22, 2019 06:20
@papandreou papandreou mentioned this pull request Jul 22, 2019
Closed
@papandreou papandreou merged commit 9e2d545 into master Jul 24, 2019
@papandreou papandreou deleted the tech/adoptSubsetFontsTransform branch July 24, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@papandreou papandreou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papandreou @coveralls @Mouvedia