Merge pull request #104 from Munter/fix/alwaysIncludeSpaceInSubset

Always include the space character U+20 in subsets
Munter · Jul 5, 2020 · 49d5625 · 49d5625
2 parents d61271e + 7c43ad1
commit 49d5625
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/subsetFonts.js b/lib/subsetFonts.js
@@ -792,6 +792,12 @@ async function subsetFonts(
           const usedCodepoints = fontUsage.text
             .split('')
             .map((c) => c.codePointAt(0));
+          if (!usedCodepoints.includes(32)) {
+            // Make sure that space is always part of the subset fonts (and that it's announced in unicode-range).
+            // Prevents Chrome from going off and downloading the fallback:
+            // https://gitter.im/assetgraph/assetgraph?at=5f01f6e13a0d3931fad4021b
+            usedCodepoints.push(32);
+          }
           const unusedCodepoints = originalCodepoints.filter(
             (n) => !usedCodepoints.includes(n)
           );

diff --git a/test/subsetFonts.js b/test/subsetFonts.js
@@ -515,7 +515,7 @@ describe('subsetFonts', function () {
                 fontFamilies: expect.it('to be a', Set),
                 codepoints: {
                   original: expect.it('to be an array'),
-                  used: [101, 108, 111, 72],
+                  used: [101, 108, 111, 32, 72],
                   unused: expect.it('to be an array'),
                 },
               },