Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NFT tokenId type #241

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

adonesky1
Copy link
Contributor

tokenId param for wallet_watchAsset should be type 'string'.

Related issue: /~https://github.com/MetaMask/MetaMask-planning/issues/853
Related PR: MetaMask/metamask-extension#19738

@adonesky1 adonesky1 requested a review from a team as a code owner June 23, 2023 18:14
@adonesky1 adonesky1 requested review from Gudahtt and danjm June 23, 2023 18:16
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit 1408449 into main Jun 23, 2023
@adonesky1 adonesky1 deleted the fix-watch-asset-nft-support-tokenid-type branch June 23, 2023 18:28
@adonesky1 adonesky1 mentioned this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants