-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #18714: Replacing deprecated constants #19843
Part of #18714: Replacing deprecated constants #19843
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
hey @georgewrmarshall, I hope its fine if I can work on these issues till theres a fix for my build error. Could you please review this PR, thanks 🙏 |
Codecov Report
@@ Coverage Diff @@
## develop #19843 +/- ##
========================================
Coverage 68.67% 68.67%
========================================
Files 988 986 -2
Lines 37959 37862 -97
Branches 10163 10135 -28
========================================
- Hits 26065 25999 -66
+ Misses 11894 11863 -31
|
Hey @dhruvv173, Would it be possible to update this PR? |
done, updated screenshots in description and added unit test screenshots. Can see visual changes changes due to updates in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @dhruvv173, looks like you have some failing e2e tests that need fixing |
Explanation
Made changes to the follow files
ui/components/app/beta-header
ui/components/app/custom-spending-cap
ui/components/app/detected-token/detected-token-address
Screenshots/Screencaps
BetaHeader
Before
After
unit test
CustomSpendingCap
Before
After
unit test
DetectedTokenAddress
Before
After
unit test
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.