Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replacing deprecated constants #19843

Merged
merged 16 commits into from
Aug 1, 2023

Conversation

dhruvv173
Copy link
Contributor

@dhruvv173 dhruvv173 commented Jun 30, 2023

Explanation

  1. ui/components/app/beta-header
  2. ui/components/app/custom-spending-cap
  3. ui/components/app/detected-token/detected-token-address

Screenshots/Screencaps

BetaHeader

Before

image
image

After

image
image
unit test
image

CustomSpendingCap

Before

image
image
image

After

image
image
image

unit test
image

DetectedTokenAddress

Before

image
image

After

image
image

unit test
image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner June 30, 2023 12:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173
Copy link
Contributor Author

hey @georgewrmarshall, I hope its fine if I can work on these issues till theres a fix for my build error. Could you please review this PR, thanks 🙏

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #19843 (c60543e) into develop (990dc33) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head c60543e differs from pull request most recent head bd6f483. Consider uploading reports for the commit bd6f483 to get more accurate results

@@           Coverage Diff            @@
##           develop   #19843   +/-   ##
========================================
  Coverage    68.67%   68.67%           
========================================
  Files          988      986    -2     
  Lines        37959    37862   -97     
  Branches     10163    10135   -28     
========================================
- Hits         26065    25999   -66     
+ Misses       11894    11863   -31     
Files Changed Coverage Δ
ui/components/app/beta-header/index.js 100.00% <ø> (ø)
...nts/app/custom-spending-cap/custom-spending-cap.js 78.41% <ø> (ø)
...n/detected-token-address/detected-token-address.js 75.00% <ø> (ø)
...ed-token-aggregators/detected-token-aggregators.js 100.00% <ø> (ø)

... and 44 files with indirect coverage changes

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 12, 2023
@georgewrmarshall
Copy link
Contributor

Hey @dhruvv173, Would it be possible to update this PR?

@dhruvv173
Copy link
Contributor Author

dhruvv173 commented Jul 25, 2023

Hey @dhruvv173, Would it be possible to update this PR?

done, updated screenshots in description and added unit test screenshots. Can see visual changes changes due to updates in the ButtonLink component

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall
Copy link
Contributor

Hey @dhruvv173, looks like you have some failing e2e tests that need fixing

@garrettbear garrettbear merged commit d375dc5 into MetaMask:develop Aug 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
@dhruvv173 dhruvv173 deleted the issue/replacing-dep-constants branch August 3, 2023 03:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants