Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog validation #10999

Merged
merged 1 commit into from
May 6, 2021
Merged

Add changelog validation #10999

merged 1 commit into from
May 6, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 6, 2021

Add changelog validation to CI, ensuring that the changelog follows the KeepAChangelog format. Additionally, this will also ensure that all of the auto-generated "Uncategorized" changelog entries on release branches get categorized.

Relates to #10752

@Gudahtt Gudahtt force-pushed the add-changelog-validation branch 2 times, most recently from e8d3bf0 to b03365d Compare May 6, 2021 16:02
Add changelog validation to CI, ensuring that the changelog follows the
KeepAChangelog format. Additionally, this will also ensure that all of
the auto-generated "Uncategorized" changelog entries on release
branches get categorized.
@Gudahtt Gudahtt force-pushed the add-changelog-validation branch from b03365d to 30752f4 Compare May 6, 2021 16:06
@Gudahtt Gudahtt marked this pull request as ready for review May 6, 2021 16:09
@Gudahtt Gudahtt requested review from kumavis and a team as code owners May 6, 2021 16:09
@Gudahtt Gudahtt requested a review from NiranjanaBinoy May 6, 2021 16:09
@metamaskbot
Copy link
Collaborator

Builds ready [30752f4]
Page Load Metrics (612 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint447761105
domContentLoaded3928096119345
load3938166129445
domInteractive3928086109345

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Gudahtt Gudahtt merged commit efb0d12 into develop May 6, 2021
@Gudahtt Gudahtt deleted the add-changelog-validation branch May 6, 2021 18:55
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants