Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@metamask/eslint-config*@6.0.0 #10858

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Apr 8, 2021

  • Add/update:
    • @metamask/eslint-config@6.0.0
    • @metamask/eslint-config-mocha@6.0.0
    • @metamask/eslint-config-nodejs@6.0.0
  • Update .eslintrc.js per new configs (base config includes prettier)
  • yarn lint:fix

Clean run:

✨ Done in 88.49s.

Cached run:

✨ Done in 5.27s.

😎

@rekmarks rekmarks requested review from kumavis and a team as code owners April 8, 2021 21:07
@rekmarks rekmarks requested a review from NiranjanaBinoy April 8, 2021 21:07
@rekmarks rekmarks force-pushed the @metamask/eslint-config@6.0.0 branch from 16b7c55 to bb92c30 Compare April 8, 2021 21:12
primary: PropTypes.string,
secondary: PropTypes.string,
identiconBorder: PropTypes.bool,
'iconClassName': PropTypes.string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it too late for me to hate this? 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitively yes! 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're accepting PRs over at /~https://github.com/MetaMask/eslint-config

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the rule thing I commented on this looks dope. I can learn to not hate the rule, if it changes it for me on save 😂

@metamaskbot
Copy link
Collaborator

Builds ready [3d983a2]
Page Load Metrics (673 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50876494
domContentLoaded43383567111053
load43483667311053
domInteractive43283567111053

@rekmarks rekmarks merged commit e18deda into develop Apr 8, 2021
@rekmarks rekmarks deleted the @metamask/eslint-config@6.0.0 branch April 8, 2021 21:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants