-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@metamask/eslint-config*@6.0.0 #10858
Conversation
16b7c55
to
bb92c30
Compare
primary: PropTypes.string, | ||
secondary: PropTypes.string, | ||
identiconBorder: PropTypes.bool, | ||
'iconClassName': PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it too late for me to hate this? 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitively yes! 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're accepting PRs over at /~https://github.com/MetaMask/eslint-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the rule thing I commented on this looks dope. I can learn to not hate the rule, if it changes it for me on save 😂
Builds ready [3d983a2]
Page Load Metrics (673 ± 53 ms)
|
@metamask/eslint-config@6.0.0
@metamask/eslint-config-mocha@6.0.0
@metamask/eslint-config-nodejs@6.0.0
.eslintrc.js
per new configs (base config includes prettier)yarn lint:fix
Clean run:
Cached run:
😎