Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MetaMask to list of BIP44 HD path examples #10703

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Add MetaMask to list of BIP44 HD path examples #10703

merged 1 commit into from
Mar 24, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Mar 23, 2021 •
edited
Loading

The "BIP44 Standard" HD path option in the Ledger connect flow listed only Trezor as an example. It seemed appropriate to include MetaMask as well, since we use the same path. This helps users who have imported their MetaMask seed phrase onto a Ledger device to discover this option.

Screenshot:

bip44-metamask

@Gudahtt
Add MetaMask to list of BIP44 HD path examples
cf4cd1d 
The "BIP44 Standard" HD path option in the Ledger connect flow listed
only Trezor as an example. It seemed appropriate to include MetaMask as
well, since we use the same path. This helps users who have imported
their MetaMask seed phrase onto a Ledger device to discover this
option.
@Gudahtt Gudahtt requested a review from a team as a code owner March 23, 2021 23:43
@Gudahtt Gudahtt requested a review from danjm March 23, 2021 23:43
@Gudahtt
Copy link
Member Author

Gudahtt commented Mar 23, 2021

This problem was highlighted in this comment: MetaMask/eth-ledger-bridge-keyring#62 (comment)

@Gudahtt Gudahtt requested review from darkwing and rachelcope March 23, 2021 23:44
@metamaskbot
Copy link
Collaborator

Builds ready [cf4cd1d]
Page Load Metrics (673 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48695873
domContentLoaded5758016715627
load5828036735527
domInteractive5758016715627

@Gudahtt Gudahtt merged commit 5bed62b into develop Mar 24, 2021
@Gudahtt Gudahtt deleted the update-bip44-path-description branch March 24, 2021 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

@darkwing darkwing Awaiting requested review from darkwing

@rachelcope rachelcope Awaiting requested review from rachelcope

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @danjm