-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Ledger Live bridge #10293
Merged
Merged
Implement Ledger Live bridge #10293
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
f8f7221
uri intent
PatrykLucka 8d15a7c
remove console log
PatrykLucka 924cb65
remove open bridge on click
PatrykLucka 08d5ecd
update add hardware wallet design
PatrykLucka 770f4da
uri intent
PatrykLucka 070c18f
remove console log
PatrykLucka 75c22ae
remove open bridge on click
PatrykLucka bde398c
update yarn.lock
PatrykLucka 6d78d85
Conditionally add assets
darkwing c0efd71
Introduce advanced feature toggle for using ledger live instead of u2f
darkwing 23710d2
Add localization
darkwing 718a52e
Send useLedgerLive setting to the user
darkwing e0f72d2
Fix metamask controller tests
darkwing 60fafe5
Don't allow non-WebUSB users to turn on Ledger Live, provide more spe…
darkwing 84ff751
Remove USB check
darkwing 931b86c
Remove irrelevant test
darkwing d7ec62b
Use async setLedgerLivePreference in controller
darkwing de08464
Fix l10n
darkwing 4b4ec1d
Don't use redux pattern for setLedgerLivePreference
darkwing ea39201
Remove rogue comma from l10n as result of rebase
darkwing 08708ad
Await keyring retrieval
darkwing e631845
Communicate the ledger live preference in the MetaMask Controller sub…
darkwing 5de54f6
Protect the updateTransportMethod call
darkwing 96e1426
Restore eth-ledger-bridge-keyring package
darkwing 09741f3
Add fallback for unsuccessful transporot update, localize text
darkwing 629ab6e
Update to ledger keyring to 0.4.0
darkwing e473bcf
Address minor feedback
darkwing daaf61e
Show loading indicator for ledger live preference toggle
darkwing e1bf3a6
Use proper CSS naming for message link
darkwing 972f2ca
Remove unused CSS class
darkwing e8c9000
Remove unnecessary pointer cursor
darkwing b907808
Re-throw error
darkwing 7b5a27a
Update text in e2e test
darkwing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Re-throw error
- Loading branch information
commit b9078088143aee9f05e1eecb7506e66e9289e336
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably re-throw the error here, so that the caller of
setLedgerLivePreference
can see that something failed.