Skip to content

Commit

Permalink
Fix check for manifest changes
Browse files Browse the repository at this point in the history
The check for manifest changes was wrong on two counts. Firstly it was
supposed to check that there *are* changes, but instead it was bailing
if there were *no* changes (the opposite of what was intended). Second,
it was including changelog changes as well, when it should have only
considered manifest changes.
  • Loading branch information
Gudahtt committed Apr 2, 2021
1 parent 3488733 commit c6c5daa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .circleci/scripts/release-commit-version-bump.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ fi

printf '%s\n' 'Commit the manifest version and changelog if the manifest has changed'

if ! git diff --quiet CHANGELOG.md app/manifest/_base.json;
if git diff --quiet app/manifest/_base.json;
then
printf '%s\n' 'No manifest changes to commit'
exit 0
Expand Down

0 comments on commit c6c5daa

Please sign in to comment.