-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ledger live bridge support #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
commented
Jan 26, 2021
darkwing
commented
Jan 26, 2021
Gudahtt
reviewed
Feb 2, 2021
darkwing
force-pushed
the
ledger-live
branch
2 times, most recently
from
February 10, 2021 18:38
b52f719
to
4526734
Compare
darkwing
force-pushed
the
ledger-live
branch
from
February 17, 2021 20:24
9ba8d98
to
6d7b974
Compare
3 tasks
Gudahtt
reviewed
Feb 23, 2021
Gudahtt
reviewed
Feb 23, 2021
brad-decker
previously approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
darkwing
force-pushed
the
ledger-live
branch
3 times, most recently
from
March 22, 2021 20:09
0a22f84
to
e3b14b3
Compare
Gudahtt
reviewed
Apr 14, 2021
Gudahtt
reviewed
Apr 14, 2021
Gudahtt
reviewed
Apr 15, 2021
Gudahtt
reviewed
Apr 15, 2021
Gudahtt
previously approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Gudahtt
approved these changes
Apr 19, 2021
julianariel
pushed a commit
to block-wallet/eth-ledger-bridge-keyring
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes: #52