Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.0.4 #354

Closed

Conversation

legobeat
Copy link
Contributor

Security-related maintenance upgrade of @lavamoat/allow-scripts.

@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 21, 2024
@legobeat legobeat marked this pull request as ready for review May 21, 2024 05:20
@legobeat legobeat requested review from a team as code owners May 21, 2024 05:20
Copy link

socket-security bot commented May 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@isaacs/cliui@8.0.2 None +6 86.8 kB isaacs
npm/@lavamoat/aa@4.2.0 None 0 19.8 kB boneskull
npm/@lavamoat/allow-scripts@3.0.4 environment 0 45.8 kB boneskull
npm/@npmcli/agent@2.2.2 environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/fs@3.1.1 filesystem 0 26.5 kB lukekarrys
npm/@npmcli/git@5.0.7 filesystem 0 21.8 kB npm-cli-ops
npm/@npmcli/package-json@5.1.0 filesystem 0 37.5 kB npm-cli-ops
npm/@npmcli/promise-spawn@7.0.2 environment, shell 0 12.2 kB npm-cli-ops
npm/@npmcli/run-script@7.0.4 environment 0 18.4 kB npm-cli-ops
npm/@pkgjs/parseargs@0.11.0 None 0 74.2 kB oss-bot
npm/abbrev@2.0.0 None 0 4.83 kB lukekarrys
npm/agent-base@7.1.1 network 0 31.2 kB tootallnate
npm/agentkeepalive@4.2.1 network 0 38.8 kB fengmk2
npm/ansi-regex@6.0.1 None 0 5.67 kB qix
npm/bin-links@4.0.3 filesystem 0 20.6 kB npm-cli-ops
npm/cacache@18.0.3 filesystem 0 63.5 kB npm-cli-ops
npm/eastasianwidth@0.2.0 None 0 13.6 kB komagata
npm/emoji-regex@9.2.2 None 0 97.9 kB google-wombot
npm/foreground-child@3.1.1 shell 0 60.4 kB isaacs
npm/fs-minipass@3.0.3 filesystem 0 14.4 kB npm-cli-ops
npm/glob@10.3.16 Transitive: environment +1 895 kB isaacs
npm/hosted-git-info@7.0.2 None 0 26.6 kB npm-cli-ops
npm/http-proxy-agent@7.0.2 network 0 23.3 kB tootallnate
npm/https-proxy-agent@7.0.4 network 0 35.3 kB tootallnate
npm/jackspeak@3.1.2 environment 0 285 kB isaacs
npm/lru-cache@10.2.2 None 0 681 kB isaacs
npm/make-fetch-happen@13.0.1 network 0 52.8 kB npm-cli-ops
npm/minipass-collect@2.0.1 None 0 4.96 kB isaacs
npm/minipass-fetch@3.0.5 environment, network 0 46.8 kB npm-cli-ops
npm/minipass@7.1.1 None 0 285 kB isaacs
npm/node-gyp@10.1.0 environment, shell +1 1.73 MB lukekarrys
npm/nopt@7.2.1 None 0 26.2 kB npm-cli-ops
npm/normalize-package-data@6.0.1 None 0 28.2 kB npm-cli-ops
npm/npm-install-checks@6.3.0 None 0 6.21 kB npm-cli-ops
npm/npm-package-arg@11.0.2 None 0 19.1 kB npm-cli-ops
npm/npm-pick-manifest@9.0.1 None 0 16.3 kB npm-cli-ops
npm/path-scurry@1.11.1 filesystem 0 535 kB isaacs
npm/proc-log@4.2.0 None 0 12.3 kB npm-cli-ops
npm/socks-proxy-agent@8.0.3 network 0 25.1 kB tootallnate
npm/spdx-correct@3.2.0 None 0 23.4 kB kemitchell
npm/ssri@10.0.6 None 0 38.7 kB npm-cli-ops
npm/string-width@5.1.2 None +1 10.1 kB sindresorhus
npm/unique-filename@3.0.0 None 0 3.41 kB lukekarrys
npm/unique-slug@4.0.0 None 0 2.58 kB lukekarrys
npm/validate-npm-package-license@3.0.4 None 0 16.6 kB kemitchell
npm/validate-npm-package-name@5.0.1 unsafe 0 7.77 kB npm-cli-ops
npm/which@4.0.0 environment Transitive: filesystem +1 50.5 kB npm-cli-ops
npm/wrap-ansi@8.1.0 None +1 29.3 kB sindresorhus

🚮 Removed packages: npm/@lavamoat/aa@3.1.5, npm/@lavamoat/allow-scripts@2.5.1, npm/@npmcli/fs@2.1.2, npm/@npmcli/promise-spawn@6.0.2, npm/@npmcli/run-script@6.0.2, npm/abbrev@1.1.1, npm/agent-base@6.0.2, npm/agentkeepalive@4.5.0, npm/bin-links@4.0.1, npm/cacache@16.1.3, npm/http-proxy-agent@5.0.0, npm/https-proxy-agent@5.0.1, npm/ip@2.0.1, npm/make-fetch-happen@10.2.1, npm/minipass-collect@1.0.2, npm/minipass-fetch@2.1.2, npm/node-gyp@9.4.1, npm/nopt@6.0.0, npm/read-package-json-fast@3.0.2, npm/socks-proxy-agent@7.0.0, npm/ssri@9.0.1, npm/unique-filename@2.0.1, npm/unique-slug@3.0.0, npm/which@3.0.1, npm/yargs@16.2.0

View full report↗︎

Copy link

socket-security bot commented May 21, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Shell access npm/foreground-child@3.1.1
Shell access npm/foreground-child@3.1.1
New author npm/abbrev@2.0.0
Network access npm/socks-proxy-agent@8.0.3
Network access npm/agent-base@7.1.1
Network access npm/agent-base@7.1.1
Network access npm/agent-base@7.1.1
Network access npm/@npmcli/agent@2.2.2
Network access npm/@npmcli/agent@2.2.2
Network access npm/@npmcli/agent@2.2.2
Network access npm/@npmcli/agent@2.2.2
Network access npm/@npmcli/agent@2.2.2
New author npm/validate-npm-package-name@5.0.1

View full report↗︎

Next steps

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/foreground-child@3.1.1
  • @SocketSecurity ignore npm/abbrev@2.0.0
  • @SocketSecurity ignore npm/socks-proxy-agent@8.0.3
  • @SocketSecurity ignore npm/agent-base@7.1.1
  • @SocketSecurity ignore npm/@npmcli/agent@2.2.2
  • @SocketSecurity ignore npm/validate-npm-package-name@5.0.1

@mcmire
Copy link
Contributor

mcmire commented Jun 5, 2024

Makes sense! Just needs to resolve conflicts.

@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from dcf25e9 to fedbe8f Compare June 6, 2024 04:43
@legobeat

This comment was marked as resolved.

@legobeat legobeat closed this Jun 6, 2024
@Mrtenz
Copy link
Member

Mrtenz commented Jun 6, 2024

@legobeat This was applied in #351, which wasn't reverted. 😅

@legobeat
Copy link
Contributor Author

legobeat commented Jun 6, 2024

@Mrtenz My bad, thanks for clarifying!

@legobeat legobeat deleted the devdeps-lavamoat-allow-scripts branch June 6, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants