Add eslint-plugin-promise and enable no-multiple-resolved (#287)

* Add eslint-plugin-promise to base package

The plugin is added to the eslint configuration, with the no-multiple-resolved rule enabled. This avoids situations where both `resolve()` and `reject()` can be called, due to a missing `return` statement.

* Update `rules-snapshot.json` to include the new rule

* Update all READMEs to include the new plugin

packages/base/README.md

@@ -14,6 +14,7 @@ yarn add --dev \
     eslint-plugin-import@^2.26.0 \
     eslint-plugin-jsdoc@^39.6.2 \
     eslint-plugin-prettier@^4.2.1 \
+    eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1
 ```
 

packages/base/package.json

@@ -28,6 +28,7 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jsdoc": "^39.6.2",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "prettier": "^2.7.1"
   },
   "peerDependencies": {
@@ -36,6 +37,7 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jsdoc": "^39.6.2",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "prettier": "^2.7.1"
   },
   "engines": {

packages/base/rules-snapshot.json

@@ -3320,6 +3320,7 @@
       "usePrettierrc": true
     }
   ],
+  "promise/no-multiple-resolved": "error",
   "quote-props": "off",
   "quotes": "off",
   "radix": "error",

packages/base/src/index.js

@@ -20,7 +20,7 @@ module.exports = {
     sourceType: 'script',
   },
 
-  plugins: ['jsdoc', 'prettier'],
+  plugins: ['jsdoc', 'prettier', 'promise'],
 
   extends: [
     'eslint:recommended',
@@ -394,5 +394,7 @@ module.exports = {
     'jsdoc/require-yields-check': 'error',
     'jsdoc/tag-lines': 'error',
     'jsdoc/valid-types': 'error',
+
+    'promise/no-multiple-resolved': 'error',
   },
 };

packages/browser/README.md

@@ -15,6 +15,7 @@ yarn add --dev \
     eslint-plugin-import@^2.26.0 \
     eslint-plugin-jsdoc@^39.6.2 \
     eslint-plugin-prettier@^4.2.1 \
+    eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1
 ```
 

packages/commonjs/README.md

@@ -13,6 +13,7 @@ yarn add --dev \
     eslint-plugin-import@^2.26.0 \
     eslint-plugin-jsdoc@^39.6.2 \
     eslint-plugin-prettier@^4.2.1 \
+    eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1
 ```
 

packages/jest/README.md

@@ -14,6 +14,7 @@ yarn add --dev \
     eslint-plugin-jsdoc@^39.6.2 \
     eslint-plugin-jest@^27.1.5 \
     eslint-plugin-prettier@^4.2.1 \
+    eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1
 ```
 

packages/mocha/README.md

@@ -14,6 +14,7 @@ yarn add --dev \
     eslint-plugin-jsdoc@^39.6.2 \
     eslint-plugin-mocha@^10.1.0 \
     eslint-plugin-prettier@^4.2.1 \
+    eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1
 ```
 

packages/nodejs/README.md

@@ -14,6 +14,7 @@ yarn add --dev \
     eslint-plugin-jsdoc@^39.6.2 \
     eslint-plugin-node@^11.1.0 \
     eslint-plugin-prettier@^4.2.1 \
+    eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1
 ```
 

packages/typescript/README.md

@@ -15,6 +15,7 @@ yarn add --dev \
     eslint-plugin-import@^2.26.0 \
     eslint-plugin-jsdoc@^39.6.2 \
     eslint-plugin-prettier@^4.2.1 \
+    eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1
 ```
 

yarn.lock

@@ -1033,13 +1033,15 @@ __metadata:
     eslint-plugin-import: ^2.26.0
     eslint-plugin-jsdoc: ^39.6.2
     eslint-plugin-prettier: ^4.2.1
+    eslint-plugin-promise: ^6.1.1
     prettier: ^2.7.1
   peerDependencies:
     eslint: ^8.27.0
     eslint-config-prettier: ^8.5.0
     eslint-plugin-import: ^2.26.0
     eslint-plugin-jsdoc: ^39.6.2
     eslint-plugin-prettier: ^4.2.1
+    eslint-plugin-promise: ^6.1.1
     prettier: ^2.7.1
   languageName: unknown
   linkType: soft
@@ -2717,6 +2719,15 @@ __metadata:
   languageName: node
   linkType: hard
 
+"eslint-plugin-promise@npm:^6.1.1":
+  version: 6.1.1
+  resolution: "eslint-plugin-promise@npm:6.1.1"
+  peerDependencies:
+    eslint: ^7.0.0 || ^8.0.0
+  checksum: 46b9a4f79dae5539987922afc27cc17cbccdecf4f0ba19c0ccbf911b0e31853e9f39d9959eefb9637461b52772afa1a482f1f87ff16c1ba38bdb6fcf21897e9a
+  languageName: node
+  linkType: hard
+
 "eslint-scope@npm:^5.1.1":
   version: 5.1.1
   resolution: "eslint-scope@npm:5.1.1"